Update ACS release notes march [deprecated] #2547
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garchiro7
requested review from
Mohit-Chakraborty,
ShivangiReja,
alzimmermsft,
czubair,
jeremymeng,
kinelski,
kyle-patterson and
xiangyan99
as code owners
weshaggard
reviewed
Mar 10, 2021
added 2 commits
March 10, 2021 17:06
vcolin7
reviewed
Mar 10, 2021
| ... | ||
| implementation 'com.azure.android:azure-communication-chat:1.0.0-beta.7' | ||
| implementation 'com.azure.android:azure-communication-common:1.0.0-beta.7' | ||
| implementation 'com.microsoft.trouter:client-android:0.0.1-beta.1' |
Member
There was a problem hiding this comment.
If Trouter is closed-source I think we should not include it in the release notes. We use these to announce changes made to our Azure SDK libraries.
Member
There was a problem hiding this comment.
JP mentioned that customers need to include this in their projects for the signaling part to work correctly, but I think instructions like these should be indicated in the README. Although I'm not entirely sure why they would need to do so if Trouter is a dependency of ACS Chat already. Are there any cases where customers would want to use Trouter APIs themselves?
Member
Author
|
This PR is outdated, the conversation will continue into the respective PR language |
garchiro7
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RezaJooyandeh, @tophpalmer, @mikben can you please take a look into?